[MNG-4504] Disallowing all aggregator bindings to any lifecycle is too broad

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Incomplete
• Affects Version/s: 2.2.1
• Component/s: Plugins and Lifecycle

Environment

Darwin nicerobot.local 9.8.0 Darwin Kernel Version 9.8.0: Wed Jul 15 16:55:01 PDT 2009; root:xnu-1228.15.4~1/RELEASE_I386 i386 i386

Apache Maven 2.2.1 (r801777; 2009-08-06 15:16:01-0400)
Java version: 1.5.0_22
Java home: /System/Library/Frameworks/JavaVM.framework/Versions/1.5.0/Home
Default locale: en, platform encoding: MacRoman
OS name: "mac os x" version: "10.5.8" arch: "i386" Family: "unix"

• Assignee: Unassigned
• Reporter: nicerobot
• Created: 25/Dec/09 18:18
• Updated: 31/Dec/23 10:45
• Resolved: 22/Jan/14 20:31

Description

I kinda understand why some aggregators can be dangerous to bind to lifecycle phases as mentioned in the docs but to disallow all aggregator bindings to any lifecycle phase seems to broad.

For example, i'm preforming scm:checkin during install.

The problem is that i get the warning:

DEPRECATED: Binding aggregator mojos to lifecycle phases in the POM is considered dangerous.

Added by 619711 to DefaultLifecycleExecutor.java

My problem is that this is bound to the install phase so it runs after the package phase, and according to the docs mentioned above for why it's being disallowed, binding an aggregator, at least scm:checkin, to install doesn't seem "dangerous" at all. At least with Mercurial, scm:checkin doesn't have side-effects that might cause an issue. So, in this case, it should be allowed.

I think, instead of removing the ability to bind aggregators to lifecycle phases, it should:

1. be a warning that it's potentially harmful.
2. only warn if binding to a phase up to and including package?
3. provide a means to suppress the warning, like, maybe an obvious tag or attribute:
   AllowAggregatorLifeCycleBinding="true"
   which is essentially, use at your own risk, you're on your own if it breaks something.

Issue Links

• is related to: MNG-7991 refactor "aggregator" goal feature