[MNG-4416] [regression] Plugins are not properly ordered after merging with profile plugins

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.0-alpha-3
• Fix Version/s: 3.0-alpha-3
• Component/s: Plugins and Lifecycle, POM, Profiles
• Assignee: Benjamin Bentmann
• Reporter: Benjamin Bentmann
• Created: 29/Oct/09 06:45
• Updated: 11/Feb/16 04:57
• Resolved: 29/Oct/09 07:34

Description

Basically the same as MNG-4415 just in the context of profiles. E.g. for a POM with

<build>
  <plugins>
    <plugin>
      <groupId>org.apache.maven.its.plugins</groupId>
      <artifactId>maven-it-plugin-b</artifactId>
      <version>2.1-SNAPSHOT</version>
    </plugin>
  </plugins>
</build>
<profiles>
  <profile>
    <id>test</id>
    <build>
      <plugins>
        <plugin>
          <groupId>org.apache.maven.its.plugins</groupId>
          <artifactId>maven-it-plugin-a</artifactId>
          <version>2.1-SNAPSHOT</version>
        </plugin>
        <plugin>
          <groupId>org.apache.maven.its.plugins</groupId>
          <artifactId>maven-it-plugin-b</artifactId>
          <version>2.1-SNAPSHOT</version>
        </plugin>
      </plugins>
    </build>
  </profile>
</profiles>

the effective model erroneously ends up with the wrong plugin order as shown below when the profile is activated:

<build>
  <plugins>
    <plugin>
      <groupId>org.apache.maven.its.plugins</groupId>
      <artifactId>maven-it-plugin-b</artifactId>
      <version>2.1-SNAPSHOT</version>
    </plugin>
    <plugin>
      <groupId>org.apache.maven.its.plugins</groupId>
      <artifactId>maven-it-plugin-a</artifactId>
      <version>2.1-SNAPSHOT</version>
    </plugin>
  </plugins>
</build>

In general, profile injection is expected to work like this when merging the plugin lists:

model:   X -> A -> B -> D -> E
profile: Y -> A -> C -> D -> F
result:  X -> Y -> A -> B -> C -> D -> E -> F

Issue Links

• is related to: MNG-4415 [regression] Plugins are not properly ordered after merging with inherited parent plugins
• relates to: MNG-5478 Order of plugin execution does not match order of definition in profile