Maven
  1. Maven
  2. MNG-4275

[regression] Direct relocations no longer log at WARNING level : MNG-3380 conflicts with MNG-1689

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2.0
    • Fix Version/s: 2.2.1
    • Component/s: Dependencies
    • Labels:
      None
    • Environment:
    • Flags:
      Patch

      Description

      Changes for MNG-3380 [1] to Process relocations before child-nodes are discovered during artifact collection, conflict with MNG-1689 [2] " Only print relocation warnings in standard output for the current pom". This results in a regression where (direct) relocations are no longer logged at WARNING level and are only logged at DEBUG. Direct relocations should be logged at WARNING level.

      @675087 [3] MNG-3380 was applied to DefaultArtifactCollector - the result is that the call to MavenMetadataSource#retrieveRelocatedArtifact() (then retrieveRelocatedProject()) occur before the call to artifact.setDependencyTrail( node.getDependencyTrail() ); in DefaultArtifactCollector. This results in a null list in MavenMetadataSource, which then fails the if-test to log at WARNING level introduced in MNG-1689.

      With a quick inspection I couldn't see the harm in bringing forward the call to:

      artifact.setDependencyTrail( node.getDependencyTrail() )

      , it is already called once when about to throw an exception, and this call can be replaced. Proposed patch makes the setDependencyTrail call earlier, prior to relocation detection.

      See also Nabble post [4].

      [1] http://jira.codehaus.org/browse/MNG-3380
      [2] http://jira.codehaus.org/browse/MNG-1689
      [3] http://svn.apache.org/viewvc?view=rev&revision=675087
      [4] http://www.nabble.com/2.0.9-%3E2.1.0-change-regression-in-relocation-WARNING--td24368186.html

        Activity

        Brett Randall created issue -
        javabrett@gmail.com made changes -
        Field Original Value New Value
        Attachment MNG-4275.maven-trunks.patch [ 43539 ]
        John Casey made changes -
        Assignee John Casey [ jdcasey ]
        Fix Version/s 2.2.1 [ 15328 ]
        Summary Direct relocations no longer log at WARNING level : MNG-3380 conflicts with MNG-1689 [regression] Direct relocations no longer log at WARNING level : MNG-3380 conflicts with MNG-1689
        John Casey made changes -
        Resolution Fixed [ 1 ]
        Status Open [ 1 ] Closed [ 6 ]
        Mark Thomas made changes -
        Project Import Sun Apr 05 08:49:45 UTC 2015 [ 1428223785911 ]
        Mark Thomas made changes -
        Workflow jira [ 12714607 ] Default workflow, editable Closed status [ 12754319 ]
        Mark Thomas made changes -
        Flags Patch [ 10430 ]
        Patch Submitted Yes [ 10763 ]
        Mark Thomas made changes -
        Project Import Sun Apr 05 21:45:26 UTC 2015 [ 1428270326204 ]
        Mark Thomas made changes -
        Workflow jira [ 12953213 ] Default workflow, editable Closed status [ 12989093 ]

          People

          • Assignee:
            John Casey
            Reporter:
            Brett Randall
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development