[MNG-3975] getArtifact(Artifact artifact, List remoteRepositories) should include Exception in debug log messages.

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.0.9
• Fix Version/s: 2.0.10, 2.1.0
• Component/s: Logging
• Environment: Any environment.
• Assignee: Benjamin Bentmann
• Reporter: Stoyan
• Created: 07/Jan/09 16:19
• Updated: 04/Mar/09 10:18
• Resolved: 14/Jan/09 14:29

Description

We recently had an issue where the local repo could not be created due to permissions issues. Unfortunately the default output of mvn -X is not helpful in debugging this issue.

In org.apache.maven.wagon.AbstractWagon:

protected void createParentDirectories( File destination )
throws TransferFailedException
{
File destinationDirectory = destination.getParentFile();
if ( destinationDirectory != null && !destinationDirectory.exists() )
{
if ( !destinationDirectory.mkdirs() )

{ throw new TransferFailedException( "Specified destination directory cannot be created: " + destinationDirectory ); }

}
}

if TransferFailedException("Specified destination directory cannot be created: " + destinationDirectory ); is thrown it eventually bubbles up to org.apache.maven.artifact.manager.DefaultWagonManager and is caught in the second catch block from this snippet of public void getArtifact( Artifact artifact, List remoteRepositories ):

try

{ getArtifact( artifact, repository ); successful = artifact.isResolved(); }

catch ( ResourceDoesNotExistException e )

{ // This one we will eat when looking through remote repositories // because we want to cycle through them all before squawking. getLogger().debug( "Unable to get resource '" + artifact.getId() + "' from repository " + repository.getId() + " (" + repository.getUrl() + ")" ); }

catch ( TransferFailedException e )

{ getLogger().debug( "Unable to get resource '" + artifact.getId() + "' from repository " + repository.getId() + " (" + repository.getUrl() + ")" ); }

Can we also include the exception in the debug log message? e.g. make this call:

getLogger().debug( "Unable to get resource '" + artifact.getId() + "' from repository " +
repository.getId() + " (" + repository.getUrl() + ")" , e);

Issue Links

• relates to: MNG-3794 Improve error logging when downloading depedencies
• relates to: MNG-4065 Unable to download the artifact from any repository