[MNG-3838] [regression] Some POMs fail to parse if the are subject to ModelContainer joining

• Type: Bug
• Status: Closed
• Priority: Blocker
• Resolution: Fixed
• Affects Version/s: 3.0-alpha-1
• Fix Version/s: 3.0-alpha-1
• Component/s: POM
• Assignee: Britton Isbell
• Reporter: Espen Wiborg
• Created: 13/Nov/08 15:18
• Updated: 22/Dec/08 06:18
• Resolved: 22/Dec/08 06:18

Description

With Maven 3.0-SNAPSHOT built from svn r713815, the POM in the attachment fails to parse with the output in fail.log. The interesting bit is reproduced here:

java.io.IOException: org.codehaus.plexus.util.xml.pull.XmlPullParserException: end tag name </plugin> must match start tag name <dependencies> from line 12 (position: START_TAG seen ...<dependencies></plugin>... @12:24) :

<project xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd"  xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"  xmlns="http://maven.apache.org/POM/4.0.0" >
<modelVersion>4.0.0</modelVersion>
<groupId>testing</groupId>
<artifactId>testing</artifactId>
<version>1</version>
<build>
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-checkstyle-plugin</artifactId>
<dependencies></plugin>
<plugin>
[...lots more...]

As far as I can make out, the problem is that the ModelContainer joining carried out in ModelTransformerContext.transform (on line 269) fails to take into account that it may leave the wrapper collection empty. Such an empty collection then leads ModelMarshaller astray later.

The example POM is a stripped-down version of the org.apache.cxf:cfx-parent:2.1 POM, which is how I discovered the issue.

This broke sometime after 2008-10-13.

Issue Links

• is related to: MNG-3821 [regression] Project builder blows up when POM declares two plugins which use the same id for their executions/reportsets