[MNG-2309] Profile activation order is random

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.0, 2.0.1, 2.0.2, 2.0.3, 2.0.4
• Fix Version/s: 2.0.5
• Component/s: Reactor and Workspace
• Environment: all
• Assignee: kenneyw
• Reporter: Kenney Westerhof
• Created: 20/May/06 11:23
• Updated: 01/Nov/11 00:28
• Resolved: 20/May/06 11:32

Description

The order in which profiles are activated is currently random.

Say you have two profiles:

<profile>
  <id>default</id>
  <properties>
    <test>DEFAULT</test>
  </properties>
</profile>

<profile>
  <id>override</id>
  <properties>
    <test>OVERRIDE</test>
  </properties>
</profile>

and you run

mvn projecthelp:effective-pom -Pdefault,override

on any pom, then then <properties> section at the bottom will
probably show

<test>DEFAULT</test>

.

The same happens if you specify '<activeProfiles><activeProfile>default</..></..>' and run with 'mvn -Poverride'.

This breaks overriding settings since the merge order is random because DefaultProfileManager uses
a HashMap to add active profiles, and HashMap iterators are random.

Proposed fix is to use a LinkedHashMap.

Issue Links

• is depended upon by: MNG-4106 [regression] Interpolation does not use properties from dominant settings profile if other profile defines same property
• is depended upon by: MNG-4107 [regression] User settings can't override properties used for POM interpolation
• relates to: MNG-4741 Priority for profiles activated by property or -P unclear
• relates to: MNG-4946 Let the order of profiles in `mvn -P...` determine their order in effective POM