[MNG-1994] Execution order of child plugins is arbitrary if inheritance is involved

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Won't Fix
• Affects Version/s: 2.0.1
• Component/s: Inheritance and Interpolation
• Flags: Patch
• Assignee: John Dennis Casey
• Reporter: John Didion
• Created: 19/Jan/06 17:25
• Updated: 04/Apr/16 16:02
• Resolved: 01/Jun/07 14:17

Description

This is related to MNG-1499, but different, and, in my opinion, equally important. It makes sense that the order of plugin execution should be the same as it appears in the POM. For example, I have two plugins: one that generates a batch file and one that executes it. These plugins must run in order or the build will fail. However, the current implementation of ModelUtils.mergePluginLists does not respect the order of child plugins.

There is also a seperate bug in that the assembledPlugins map is being checked for the presence of child plugins before adding them to the mergedPlugins list, but nothing is ever added to assembledPlugins. So if a plugin exists in a parent and a child, it will end up appearing twice in the child's plugin list.

I have re-written this method to fix both these problems. See attached.

Issue Links

• is related to: MNG-5994 add explicit ordering support for plugins
• is related to: MNG-3808 Execution order of report plugins is arbitrary if inheritance is involved
• relates to: MNG-2258 Wrong execution order of plugins in same phase
• relates to: MNG-1499 Execution order is arbitrary if inheritance is involved