[MNEMONIC-180] Missing throw for NoSuchElementException();

• Type: Bug
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Fix Version/s: 0.5.0-incubating
• Assignee: Gordon King
• Reporter: JC
• Created: 09/Jan/17 17:49
• Updated: 26/Jan/17 21:59
• Resolved: 09/Jan/17 18:16

Description

In recent snapshot from Github, it seems there is an exception (new NoSuchElementException) that is not thrown. (mnemonic-collections/src/main/java/org/apache/mnemonic/collections/DurableSinglyLinkedList.java)

162     @Override
163     public E next() {
164       if (null == next) {
165         new NoSuchElementException();
166       }
167       E ret = next.getItem();
168       next = next.getNext();
169       return ret;
170     }

Should it be as follows?

...
164       if (null == next) {
165         throw new NoSuchElementException();
166       }
...