Uploaded image for project: 'Maven JMod Plugin'
  1. Maven JMod Plugin
  2. MJMOD-5

Usage of moduleName in describe/list goal / classpath usage in create goal

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 3.0.0-alpha-1
    • Fix Version/s: 3.0.0-alpha-1
    • Labels:
      None

      Description

      The create goal uses classpath which should be prevented and replaced.
      The list and describe goals using moduleName which is misleading cause we only use the name of the jmod file. Not related to a module name in any way.

        Activity

        Hide
        khmarbaise Karl Heinz Marbaise added a comment -

        Done in r1808613

        Show
        khmarbaise Karl Heinz Marbaise added a comment - Done in r1808613
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build maven-plugins #9139 (See https://builds.apache.org/job/maven-plugins/9139/)
        MJMOD-5 Usage of moduleName in describe/list goal / classpath usage in create goal
        o in describe/list goal change the moduleName into jmodFile using
        a default or can be given explicit by a property.
        Added IT's for direct call of the goals describe/list.
        o Removed the parameter classPath from the goal create. The command line
        will got the information from pathElements instead. (khmarbaise: http://svn.apache.org/viewvc/?view=rev&rev=1808613)

        • (add) maven-jmod-plugin/src/it/describe-plain
        • (add) maven-jmod-plugin/src/it/describe-plain/invoker.properties
        • (add) maven-jmod-plugin/src/it/describe-plain/pom.xml
        • (add) maven-jmod-plugin/src/it/describe-plain/src
        • (add) maven-jmod-plugin/src/it/describe-plain/src/main
        • (add) maven-jmod-plugin/src/it/describe-plain/src/main/configs
        • (add) maven-jmod-plugin/src/it/describe-plain/src/main/configs/config.test
        • (add) maven-jmod-plugin/src/it/describe-plain/src/main/java
        • (add) maven-jmod-plugin/src/it/describe-plain/src/main/java/module-info.java
        • (add) maven-jmod-plugin/src/it/describe-plain/src/main/java/myproject
        • (add) maven-jmod-plugin/src/it/describe-plain/src/main/java/myproject/HelloWorld.java
        • (add) maven-jmod-plugin/src/it/describe-plain/verify.groovy
        • (add) maven-jmod-plugin/src/it/list-plain
        • (add) maven-jmod-plugin/src/it/list-plain/invoker.properties
        • (add) maven-jmod-plugin/src/it/list-plain/pom.xml
        • (add) maven-jmod-plugin/src/it/list-plain/src
        • (add) maven-jmod-plugin/src/it/list-plain/src/main
        • (add) maven-jmod-plugin/src/it/list-plain/src/main/configs
        • (add) maven-jmod-plugin/src/it/list-plain/src/main/configs/config.test
        • (add) maven-jmod-plugin/src/it/list-plain/src/main/java
        • (add) maven-jmod-plugin/src/it/list-plain/src/main/java/module-info.java
        • (add) maven-jmod-plugin/src/it/list-plain/src/main/java/myproject
        • (add) maven-jmod-plugin/src/it/list-plain/src/main/java/myproject/HelloWorld.java
        • (add) maven-jmod-plugin/src/it/list-plain/verify.groovy
        • (edit) maven-jmod-plugin/src/main/java/org/apache/maven/plugins/jmod/JModCreateMojo.java
        • (edit) maven-jmod-plugin/src/main/java/org/apache/maven/plugins/jmod/JModDescribeMojo.java
        • (edit) maven-jmod-plugin/src/main/java/org/apache/maven/plugins/jmod/JModListMojo.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build maven-plugins #9139 (See https://builds.apache.org/job/maven-plugins/9139/ ) MJMOD-5 Usage of moduleName in describe/list goal / classpath usage in create goal o in describe/list goal change the moduleName into jmodFile using a default or can be given explicit by a property. Added IT's for direct call of the goals describe/list. o Removed the parameter classPath from the goal create. The command line will got the information from pathElements instead. (khmarbaise: http://svn.apache.org/viewvc/?view=rev&rev=1808613 ) (add) maven-jmod-plugin/src/it/describe-plain (add) maven-jmod-plugin/src/it/describe-plain/invoker.properties (add) maven-jmod-plugin/src/it/describe-plain/pom.xml (add) maven-jmod-plugin/src/it/describe-plain/src (add) maven-jmod-plugin/src/it/describe-plain/src/main (add) maven-jmod-plugin/src/it/describe-plain/src/main/configs (add) maven-jmod-plugin/src/it/describe-plain/src/main/configs/config.test (add) maven-jmod-plugin/src/it/describe-plain/src/main/java (add) maven-jmod-plugin/src/it/describe-plain/src/main/java/module-info.java (add) maven-jmod-plugin/src/it/describe-plain/src/main/java/myproject (add) maven-jmod-plugin/src/it/describe-plain/src/main/java/myproject/HelloWorld.java (add) maven-jmod-plugin/src/it/describe-plain/verify.groovy (add) maven-jmod-plugin/src/it/list-plain (add) maven-jmod-plugin/src/it/list-plain/invoker.properties (add) maven-jmod-plugin/src/it/list-plain/pom.xml (add) maven-jmod-plugin/src/it/list-plain/src (add) maven-jmod-plugin/src/it/list-plain/src/main (add) maven-jmod-plugin/src/it/list-plain/src/main/configs (add) maven-jmod-plugin/src/it/list-plain/src/main/configs/config.test (add) maven-jmod-plugin/src/it/list-plain/src/main/java (add) maven-jmod-plugin/src/it/list-plain/src/main/java/module-info.java (add) maven-jmod-plugin/src/it/list-plain/src/main/java/myproject (add) maven-jmod-plugin/src/it/list-plain/src/main/java/myproject/HelloWorld.java (add) maven-jmod-plugin/src/it/list-plain/verify.groovy (edit) maven-jmod-plugin/src/main/java/org/apache/maven/plugins/jmod/JModCreateMojo.java (edit) maven-jmod-plugin/src/main/java/org/apache/maven/plugins/jmod/JModDescribeMojo.java (edit) maven-jmod-plugin/src/main/java/org/apache/maven/plugins/jmod/JModListMojo.java

          People

          • Assignee:
            khmarbaise Karl Heinz Marbaise
            Reporter:
            khmarbaise Karl Heinz Marbaise
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development