Uploaded image for project: 'Maven Javadoc Plugin'
  1. Maven Javadoc Plugin
  2. MJAVADOC-570

--add-modules expects comma-separated arguments

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.1.0
    • Fix Version/s: 3.1.0
    • Component/s: javadoc
    • Labels:
      None

      Description

      It's quicker for me to explain this problem that produce a minimal testcase for it. In AbstractJavadocMojo line 5079 we invoke:

      addArgIfNotEmpty( arguments, "--add-modules", JavadocUtil.quotedPathArgument( addModulesLine ) );

      This gets converted to addArgIfNotEmpty() with splitValue=true which means that comma-separated values get converted to newline-separated values. 

      --add-modules does not like this and does not consume the subsequent arguments (they probably get treated as source files instead).

      We should be invoking addArgIfNotEmpty() with splitValue=false instead.

      If I provide a PR for this, do you still need a testcase?

      On a side-note, it would really help if they documented the expected behavior. I only ran across this by chance due to this bug report on OpenJDK: https://bugs.openjdk.java.net/browse/JDK-8165634 and when I converted newline to commas in my own project one of the error messages went away.

        Attachments

          Activity

            People

            • Assignee:
              rfscholte Robert Scholte
              Reporter:
              cowwoc Gili
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: