[MJAVADOC-565] Make proxy configuration properly work for both HTTP and HTTPS

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.0.1
• Fix Version/s: 3.1.0
• Assignee: Michael Osipov
• Reporter: Bill Shannon
• Created: 16/Jan/19 22:19
• Updated: 15/Mar/19 12:33
• Resolved: 28/Feb/19 07:34

Description

There seems to be some disagreement about how to configure web proxy servers.

Maven seems to think that the "protocol" element specifies the protocol to use when talking to the web proxy server, and thus allows only one proxy to be configured in settings.xml.  (Or rather, only the first configured proxy is used.)  That's not the way proxy servers work.

The JDK configures web proxy servers based on the protocol that's being proxied.

For example, when using a <link> to access the JDK javadocs, https is needed.  The maven-javadoc-plugin invokes the external javadoc command with these arguments:

-J-Dhttp.proxySet=true -J-Dhttp.proxyHost=<proxy-host> -J-Dhttp.proxyPort=<proxy-port>

That only configures the proxy for the http protocol, not the https protocol, and thus the linked resource can not be accessed.  To configure the proxy to be used for the https protocol, the following arguments are needed:

-J-Dhttps.proxySet=true -J-Dhttps.proxyHost=<proxy-host> -J-Dhttps.proxyPort=<proxy-port>

 

Issue Links

• contains: MJAVADOC-447 Command line dump reveals proxy user/password in case of errors
• is duplicated by: MJAVADOC-483 Needs support for https.proxySet etc.
• relates to: MNG-5950 Only first active proxy considered
• relates to: MJAVADOC-483 Needs support for https.proxySet etc.
• relates to: MNG-6413 Redesign proxies in Settings