Maven Javadoc Plugin
  1. Maven Javadoc Plugin
  2. MJAVADOC-406

Regression: MJAVADOC-398 commit changed wrong line

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 2.10
    • Fix Version/s: 2.10.1
    • Component/s: None
    • Labels:
      None

      Description

      The "functionality"/change behavior of MJAVADOC-398 should definitely be configurable.

      In our project we have to manually put a lot of dependencies into <additionalDependencies> section to restore the previously working behaviour which is a huge pain and does not scale (as we will be forced to update the dependencies every time dependencies are added to projects).

      Please provide a javadoc configuration for turning on/off the "functionality" added in MJAVADOC-398.

        Issue Links

          Activity

          Show
          David Liszewski added a comment - Per indications from the user community, MJAVADOC-398 was a gross mistake. http://stackoverflow.com/questions/25983852/maven-javadoc-plugin-breaks-mvn-releaseperform/25986409#25986409 http://stackoverflow.com/questions/25971832/javadoc-generation-failed-classcastexception-com-sun-tools-javadoc-classdocim http://jira.codehaus.org/browse/MJAVADOC-406
          Hide
          Michael Osipov added a comment -

          As it turns out, this commit was incorrect. Are you able to test a SNAPSHOT which I will upload soon?

          Show
          Michael Osipov added a comment - As it turns out, this commit was incorrect. Are you able to test a SNAPSHOT which I will upload soon?
          Hide
          David Liszewski added a comment -

          Thanks Michael.
          How would I test it with maven-release-plugin, as that was failing in release:perform which doesn't have an option to allow SNAPSHOT dependencies?

          Show
          David Liszewski added a comment - Thanks Michael. How would I test it with maven-release-plugin , as that was failing in release:perform which doesn't have an option to allow SNAPSHOT dependencies?
          Hide
          Michael Osipov added a comment -

          David, you do not depend on a SNAPSHOT dependency but on a SNAPSHOT plugin. But I guess that would have the same outcome. You can test it the following way:

          1. Have Maven download the SNAPSHOT from Apache Snaphots Repo
          2. Change the version number manually to something non-SNAPSHOT
          3. Try your mvn release:prepare release:perform.

          Show
          Michael Osipov added a comment - David, you do not depend on a SNAPSHOT dependency but on a SNAPSHOT plugin. But I guess that would have the same outcome. You can test it the following way: 1. Have Maven download the SNAPSHOT from Apache Snaphots Repo 2. Change the version number manually to something non-SNAPSHOT 3. Try your mvn release:prepare release:perform .
          Hide
          Robert Scholte added a comment -

          There's absolutely no reason to do this with the maven-release-plugin. Just use the same arguments as release:perform does: mvn deploy site-deploy -Prelease-profile

          Show
          Robert Scholte added a comment - There's absolutely no reason to do this with the maven-release-plugin. Just use the same arguments as release:perform does: mvn deploy site-deploy -Prelease-profile
          Hide
          Michael Osipov added a comment - - edited

          David, I just have deployed a new SNAPSHOT which restores the previous behavior and really fixed MJAVADOC-398. Please test and report.

          If change is verified, I will push 2.10.1 immediately.

          Show
          Michael Osipov added a comment - - edited David, I just have deployed a new SNAPSHOT which restores the previous behavior and really fixed MJAVADOC-398 . Please test and report. If change is verified, I will push 2.10.1 immediately.
          Hide
          Martin Skurla added a comment -

          I was able always to reproduce the behaviour by:

          mvn javadoc:aggregate
          
          Show
          Martin Skurla added a comment - I was able always to reproduce the behaviour by: mvn javadoc:aggregate
          Hide
          Michael Osipov added a comment -

          Thanks for the confimation guys! I will commit as-is now and proceed with an immediate vote for 2.10.1 today.

          Show
          Michael Osipov added a comment - Thanks for the confimation guys! I will commit as-is now and proceed with an immediate vote for 2.10.1 today.
          Hide
          Michael Osipov added a comment -

          Fixed with revision 1627863.

          Show
          Michael Osipov added a comment - Fixed with revision 1627863.
          Hide
          Gert Dewit added a comment -

          This one has bitten our organization quite bad, any idea when the release will be executed ?

          We'd like to evaluate if it is worth our while to change all projects pluginmanagement to use version 2.9.1 of the maven-javadoc-plugin

          Show
          Gert Dewit added a comment - This one has bitten our organization quite bad, any idea when the release will be executed ? We'd like to evaluate if it is worth our while to change all projects pluginmanagement to use version 2.9.1 of the maven-javadoc-plugin
          Hide
          Michael Osipov added a comment -

          Today!

          Show
          Michael Osipov added a comment - Today!
          Hide
          David Liszewski added a comment -

          I'm seeing 2.10.1 in Maven Central and our release builds are now proceeding without having to pin javadoc plugin version.

          Thank you Michael Osipov for getting this out so quickly, and thank you to Martin Skurla for reporting this.

          Show
          David Liszewski added a comment - I'm seeing 2.10.1 in Maven Central and our release builds are now proceeding without having to pin javadoc plugin version. Thank you Michael Osipov for getting this out so quickly, and thank you to Martin Skurla for reporting this.
          Hide
          Michael Osipov added a comment -

          David, it is abolutely imperative to pin a dependency version. Otherwise you will never have reproducible builds.

          Show
          Michael Osipov added a comment - David, it is abolutely imperative to pin a dependency version. Otherwise you will never have reproducible builds.

            People

            • Assignee:
              Michael Osipov
              Reporter:
              Martin Skurla
            • Votes:
              5 Vote for this issue
              Watchers:
              10 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development