[MJAVADOC-347] javadoc:aggregate-jar doesn't create Javadoc JAR if failOnError=false and there is an error

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.8.1
• Fix Version/s: 2.10.3
• Assignee: Karl Heinz Marbaise
• Reporter: Luis Miranda
• Created: 17/Jul/12 21:13
• Updated: 29/Mar/15 08:04
• Resolved: 29/Mar/15 08:04

Description

We are generating Javadocs for a large multi-module build, so there are bound to be some errors (for example, in 3rd party dependencies).

Currently we set failOnError=false, but we found that the aggregate-jar MOJO does not produce a JAR if there are errors. The problem comes down to this code in JavadocJar:

        try
        {
            executeReport( Locale.getDefault() );

            if ( innerDestDir.exists() )
            {
                File outputFile = generateArchive( innerDestDir, finalName + "-" + getClassifier() + ".jar" );

                if ( !attach )
                {
                    getLog().info( "NOT adding javadoc to attached artifacts list." );
                }
                else
                {
                    // TODO: these introduced dependencies on the project are going to become problematic - can we expor
                    //  through metadata instead?
                    projectHelper.attachArtifact( project, "javadoc", getClassifier(), outputFile );
                }
            }
        }
        catch ( ArchiverException e )
        {
            failOnError( "ArchiverException: Error while creating archive", e );
        }
        catch ( IOException e )
        {
            failOnError( "IOException: Error while creating archive", e );
        }
        catch ( MavenReportException e )
        {
            failOnError( "MavenReportException: Error while creating archive", e );
        }
        catch ( RuntimeException e )
        {
            failOnError( "RuntimeException: Error while creating archive", e );
        }

If there is an error in executeReport( Locale.getDefault() ) then the MOJO will just give up and not try to create the archive. I think that if failOnError is set, then we should try to create the archive anyway.