Maven JAR Plugin
  1. Maven JAR Plugin
  2. MJAR-75

[PATCH] Wrong artifact type attached to the project by the test-jar goal

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 2.0, 2.1, 2.2
    • Fix Version/s: 2.2
    • Component/s: None
    • Labels:
      None
    • Environment:
      All
    • Flags:
      Patch

      Description

      The test-jar goal attaches to the project "org.apache.maven.its.it0121:model:jar" such a artifact:

      • org.apache.maven.its.it0121:model:jar:tests
        It should attach such an artifact:
      • org.apache.maven.its.it0121:model:test-jar:tests

      The wrong artifacts "naming" leads to MNG-2871 problem:
      The code does not work (because the strings are different:
      -----------------MavenProject: replaceWithActiveArtifact(...)--------------------------------------------
      ....
      Iterator itr = ref.getAttachedArtifacts().iterator();
      while(itr.hasNext()) {
      Artifact attached = (Artifact) itr.next();
      if( attached.getDependencyConflictId().equals(pluginArtifact.getDependencyConflictId()) )

      { ... (resolve as active's project) ... }

      ...
      -------------------------------------------------------------------------------------------------------------------------------------------
      pluginArtifact.getDependencyConflictId() is : org.apache.maven.its.it0121:model:test-jar:tests
      attached.getDependencyConflictId() is : org.apache.maven.its.it0121:model:jar:tests

      For test-case: look at test (it121) attached to: http://jira.codehaus.org/browse/MNG-2871

        Issue Links

          Activity

          Piotr Tabor created issue -
          Hide
          Piotr Tabor added a comment -

          Patch

          Show
          Piotr Tabor added a comment - Patch
          Piotr Tabor made changes -
          Field Original Value New Value
          Attachment maven-jar-plugin-MJAR-75.diff [ 27857 ]
          Piotr Tabor made changes -
          Link This issue is depended upon by MNG-2871 [ MNG-2871 ]
          Piotr Tabor made changes -
          Link This issue is depended upon by MNG-3043 [ MNG-3043 ]
          Jason van Zyl made changes -
          Assignee Jason van Zyl [ jason ]
          Hide
          Piotr Tabor added a comment -

          Dedicated IT for this issue attached.

          Show
          Piotr Tabor added a comment - Dedicated IT for this issue attached.
          Piotr Tabor made changes -
          Attachment MJAR-75-core-integration-testing.diff [ 28916 ]
          John Casey made changes -
          Assignee Jason van Zyl [ jason ] John Casey [ jdcasey ]
          Hide
          John Casey added a comment -

          Applied, thanks.

          Show
          John Casey added a comment - Applied, thanks.
          John Casey made changes -
          Resolution Fixed [ 1 ]
          Fix Version/s 2.2 [ 12878 ]
          Status Open [ 1 ] Closed [ 6 ]
          Piotr Tabor made changes -
          Link This issue is depended upon by MNG-2045 [ MNG-2045 ]
          Paul Gier made changes -
          Link This issue is depended upon by MRELEASE-285 [ MRELEASE-285 ]
          Ceki Gulcu made changes -
          Link This issue is depended upon by MNG-3804 [ MNG-3804 ]
          Brian Fox made changes -
          Link This issue is depended upon by MNG-3804 [ MNG-3804 ]
          Benjamin Bentmann made changes -
          Link This issue is depended upon by MNG-3076 [ MNG-3076 ]
          Obi Ezechukwu made changes -
          Link This issue is depended upon by MNG-4248 [ MNG-4248 ]
          Mark Thomas made changes -
          Project Import Sun Apr 05 10:31:03 UTC 2015 [ 1428229863560 ]
          Mark Thomas made changes -
          Link This issue is depended upon by MRELEASE-285 [ MRELEASE-285 ]
          Mark Thomas made changes -
          Workflow jira [ 12721968 ] Default workflow, editable Closed status [ 12759484 ]
          Mark Thomas made changes -
          Flags Patch [ 10430 ]
          Patch Submitted Yes [ 10763 ]
          Mark Thomas made changes -
          Project Import Mon Apr 06 00:05:23 UTC 2015 [ 1428278723217 ]
          Mark Thomas made changes -
          Link This issue is depended upon by MRELEASE-285 [ MRELEASE-285 ]
          Mark Thomas made changes -
          Workflow jira [ 12959579 ] Default workflow, editable Closed status [ 12996516 ]
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Closed Closed
          67d 21h 5m 1 John Casey 14/Aug/07 16:08

            People

            • Assignee:
              John Casey
              Reporter:
              Piotr Tabor
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development