Uploaded image for project: 'Maven Invoker Plugin'
  1. Maven Invoker Plugin
  2. MINVOKER-219

Change default value for cloneProjectsTo and cloneClean

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.0.0
    • Labels:
      None

      Description

      Up until now cloneProjectsTo is never set, which means that by default the source-directory gets polluted with the IT test execution.
      You often see this parameter is set to target/its, so let's use that as the new default.
      To ensure the IT output-folder is in the correct state, it is also better the set cloneClean to true by default. This is more efficient compared to mvn clean because only a subset of the folders are cleaned.

        Activity

        Hide
        rfscholte Robert Scholte added a comment -

        Fixed in 1795362

        Show
        rfscholte Robert Scholte added a comment - Fixed in 1795362
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build maven-plugins #8966 (See https://builds.apache.org/job/maven-plugins/8966/)
        MINVOKER-219 Change default value for cloneProjectsTo and cloneClean (rfscholte: http://svn.apache.org/viewvc/?view=rev&rev=1795362)

        • (edit) maven-invoker-plugin/src/it/local-repo-default/verify.bsh
        • (edit) maven-invoker-plugin/src/it/script-context/verify.bsh
        • (edit) maven-invoker-plugin/src/it/script-errors/verify.bsh
        • (edit) maven-invoker-plugin/src/it/script-interpreter-detection/verify.bsh
        • (edit) maven-invoker-plugin/src/it/selector-conditions/verify.bsh
        • (edit) maven-invoker-plugin/src/it/selector-scripts/verify.bsh
        • (edit) maven-invoker-plugin/src/main/java/org/apache/maven/plugins/invoker/AbstractInvokerMojo.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build maven-plugins #8966 (See https://builds.apache.org/job/maven-plugins/8966/ ) MINVOKER-219 Change default value for cloneProjectsTo and cloneClean (rfscholte: http://svn.apache.org/viewvc/?view=rev&rev=1795362 ) (edit) maven-invoker-plugin/src/it/local-repo-default/verify.bsh (edit) maven-invoker-plugin/src/it/script-context/verify.bsh (edit) maven-invoker-plugin/src/it/script-errors/verify.bsh (edit) maven-invoker-plugin/src/it/script-interpreter-detection/verify.bsh (edit) maven-invoker-plugin/src/it/selector-conditions/verify.bsh (edit) maven-invoker-plugin/src/it/selector-scripts/verify.bsh (edit) maven-invoker-plugin/src/main/java/org/apache/maven/plugins/invoker/AbstractInvokerMojo.java
        Hide
        pwebb Phillip Webb added a comment -

        This change has unfortunately broken the ability to bypass cloning. See MINVOKER-224 for details.

        Show
        pwebb Phillip Webb added a comment - This change has unfortunately broken the ability to bypass cloning. See MINVOKER-224 for details.

          People

          • Assignee:
            rfscholte Robert Scholte
            Reporter:
            rfscholte Robert Scholte
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development