Uploaded image for project: 'Maven Invoker Plugin'
  1. Maven Invoker Plugin
  2. MINVOKER-213

The plugin should escape any XML special characters (&<>) during interpolating XML files.

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.0.0
    • Labels:
      None

      Description

      When interpolating XML files, the plugin does not escape any special XML characters and may produce invalid XML. Building a project from inside a directory like "directory name with spaces and & special char" is not possible if that directory name is interpolated into XML files where the "&" character leads to broken XML.

        Activity

        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build maven-plugins #8257 (See https://builds.apache.org/job/maven-plugins/8257/)
        MINVOKER-213 The plugin should escape any XML special characters (&<>) during interpolating XML files.

        o Updated to use maven-invoker-plugin 3.0.0-SNAPSHOT due make the ITs run on Windows. (schulte: http://svn.apache.org/viewvc/?view=rev&rev=1776659)

        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build maven-plugins #8257 (See https://builds.apache.org/job/maven-plugins/8257/ ) MINVOKER-213 The plugin should escape any XML special characters (&<>) during interpolating XML files. o Updated to use maven-invoker-plugin 3.0.0-SNAPSHOT due make the ITs run on Windows. (schulte: http://svn.apache.org/viewvc/?view=rev&rev=1776659 ) (edit) maven-assembly-plugin/pom.xml MINVOKER-213 The plugin should escape any XML special characters (&<>) during interpolating XML files. (schulte: http://svn.apache.org/viewvc/?view=rev&rev=1776657 ) (edit) maven-invoker-plugin/src/main/java/org/apache/maven/plugin/invoker/AbstractInvokerMojo.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build maven-plugins #8262 (See https://builds.apache.org/job/maven-plugins/8262/)
        MINVOKER-213 The plugin should escape any XML special characters (&<>) during interpolating XML files.

        o Updated to only escape characters leading to invalid XML if not escaped.
        I did run the ITs locally and they succeeded. On Jenkins they fail. (schulte: http://svn.apache.org/viewvc/?view=rev&rev=1776671)

        • (edit) maven-invoker-plugin/src/main/java/org/apache/maven/plugin/invoker/AbstractInvokerMojo.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build maven-plugins #8262 (See https://builds.apache.org/job/maven-plugins/8262/ ) MINVOKER-213 The plugin should escape any XML special characters (&<>) during interpolating XML files. o Updated to only escape characters leading to invalid XML if not escaped. I did run the ITs locally and they succeeded. On Jenkins they fail. (schulte: http://svn.apache.org/viewvc/?view=rev&rev=1776671 ) (edit) maven-invoker-plugin/src/main/java/org/apache/maven/plugin/invoker/AbstractInvokerMojo.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build maven-plugins #8368 (See https://builds.apache.org/job/maven-plugins/8368/)
        MINVOKER-213 The plugin should escape any XML special characters (&<>) during interpolating XML files. (schulte: http://svn.apache.org/viewvc/?view=rev&rev=1777398)

        • (edit) maven-assembly-plugin/pom.xml
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build maven-plugins #8368 (See https://builds.apache.org/job/maven-plugins/8368/ ) MINVOKER-213 The plugin should escape any XML special characters (&<>) during interpolating XML files. (schulte: http://svn.apache.org/viewvc/?view=rev&rev=1777398 ) (edit) maven-assembly-plugin/pom.xml
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build maven-plugins #8890 (See https://builds.apache.org/job/maven-plugins/8890/)
        MINVOKER-213 The plugin should escape any XML special characters (&<>) during interpolating XML files.

        o Updated to correct a compilation issue introduced by last commit. (schulte: http://svn.apache.org/viewvc/?view=rev&rev=1783819)

        • (edit) maven-invoker-plugin/src/test/java/org/apache/maven/plugin/invoker/InterpolationTest.java
          MINVOKER-213 The plugin should escape any XML special characters (&<>) during interpolating XML files.

        o Updated to also escape any values from the MavenProject instance. (schulte: http://svn.apache.org/viewvc/?view=rev&rev=1783818)

        • (edit) maven-invoker-plugin/src/main/java/org/apache/maven/plugin/invoker/AbstractInvokerMojo.java
        • (edit) maven-invoker-plugin/src/main/java/org/apache/maven/plugin/invoker/CompositeMap.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build maven-plugins #8890 (See https://builds.apache.org/job/maven-plugins/8890/ ) MINVOKER-213 The plugin should escape any XML special characters (&<>) during interpolating XML files. o Updated to correct a compilation issue introduced by last commit. (schulte: http://svn.apache.org/viewvc/?view=rev&rev=1783819 ) (edit) maven-invoker-plugin/src/test/java/org/apache/maven/plugin/invoker/InterpolationTest.java MINVOKER-213 The plugin should escape any XML special characters (&<>) during interpolating XML files. o Updated to also escape any values from the MavenProject instance. (schulte: http://svn.apache.org/viewvc/?view=rev&rev=1783818 ) (edit) maven-invoker-plugin/src/main/java/org/apache/maven/plugin/invoker/AbstractInvokerMojo.java (edit) maven-invoker-plugin/src/main/java/org/apache/maven/plugin/invoker/CompositeMap.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build maven-plugins #8891 (See https://builds.apache.org/job/maven-plugins/8891/)
        MINVOKER-213 The plugin should escape any XML special characters (&<>) during interpolating XML files. (schulte: http://svn.apache.org/viewvc/?view=rev&rev=1784076)

        • (edit) maven-invoker-plugin/src/main/java/org/apache/maven/plugin/invoker/AbstractInvokerMojo.java
        • (edit) maven-invoker-plugin/src/main/java/org/apache/maven/plugin/invoker/CompositeMap.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build maven-plugins #8891 (See https://builds.apache.org/job/maven-plugins/8891/ ) MINVOKER-213 The plugin should escape any XML special characters (&<>) during interpolating XML files. (schulte: http://svn.apache.org/viewvc/?view=rev&rev=1784076 ) (edit) maven-invoker-plugin/src/main/java/org/apache/maven/plugin/invoker/AbstractInvokerMojo.java (edit) maven-invoker-plugin/src/main/java/org/apache/maven/plugin/invoker/CompositeMap.java

          People

          • Assignee:
            schulte77 Christian Schulte
            Reporter:
            schulte77 Christian Schulte
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development