[MINSTALL-18] Bad algorithm to decide if the main artifact is to be installed or not

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.1
• Fix Version/s: 2.3
• Assignee: Benjamin Bentmann
• Reporter: Vincent Massol
• Created: 08/Apr/06 07:26
• Updated: 12/Jan/16 21:29
• Resolved: 01/Jan/09 07:09

Description

Here' s what's in InstallMojo's execute method:

                // Here, we have a temporary solution to MINSTALL-3 (isDirectory() is true if it went through compile
                // but not package). We are designing in a proper solution for Maven 2.1
                if ( file != null && !file.isDirectory() )
                {
                    installer.install( file, artifact, localRepository );
                }
                else if ( !attachedArtifacts.isEmpty() )
                {
                    getLog().info( "No primary artifact to install, installing attached artifacts instead." );
                }

This fails if we're building a JAR with no sources but with an attached artifact and only the attached artifact is created (this is the case when using the clover plugin). In that case, the install mojo tries to install the main artifact which doesn't exist).

The error is in "!file.isDirectory". In the case of a jar with no sources, this directory will not have been created...

Issue Links

• is duplicated by: MINSTALL-40 install with classifier with no target/classes fails
• is related to: MINSTALL-118 MavenProject with only attachments must have packaging "pom"
• is related to: MINSTALL-3 The install plugin fails if there are only "attached" artifacts.