Uploaded image for project: 'Apache NiFi MiNiFi C++'
  1. Apache NiFi MiNiFi C++
  2. MINIFICPP-678

Improve const correctness of code base.

    XMLWordPrintableJSON

Details

    • Epic
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • None
    • 0.9.0
    • None
    • Const Correctness

    Description

      As per MINIFICPP-676 we should improve our long term const correctness. I agree that this is a good idea ( thanks to aboda for calling this out in his PR), especially one that I haven't put a lot of emphasis on changing in code that has been around a while.

      For non stream or memory transfer objects, we want to maintain const correctness. In some cases it makes sense, especially for equality comparisons and getters to make changes. In some places it may require some evaluation and tested. Since we are an established open source projects, might need to safeguard certain changes and do full integration testing when we can. 

       

      In all cases, we should test all extensions before any merge.  We can split these efforts up as we see fit, but all tickets are relatively minor unless there is an established bug resulting from that behavior. I'd like to start a release of 0.6.0 soon so we should attempt to minimize overall impact to this release and take great care in what we change. 

      Attachments

        Activity

          People

            phrocker Marc Parisi
            phrocker Marc Parisi
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: