[MINIFICPP-265] Disable incidental -fsanitize address

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 0.3.0
• Assignee: Andrew Christianson
• Reporter: Andrew Christianson
• Created: 25/Oct/17 14:54
• Updated: 10/Jan/18 20:03
• Resolved: 31/Oct/17 14:16

Description

From nifi dev mailing list:

"On an earlier commit, I added the following to the root CMakeLists.txt:

1. Enable asan in DEBUG for compatibility with civet
   set(CMAKE_CXX_FLAGS_DEBUG "${CMAKE_CXX_FLAGS_DEBUG} -fsanitize=address")

This was, as stated in the comment, to address a compatibility issue when compiling in DEBUG where civet would fail to link.

On more recent dev toolchains (devtoolset-6 SCL CentOS/GCC 6.3), this results in extremely verbose and unhelpful output during test runs. While I am not opposed to using these tools to detect legitimate memory leaks, as it stands currently the setting is more of a detriment to the development process. I think that we should either only turn this on when we deliberately intend to analyze memory usage, or possibly create additional unit tests to detect memory leaks."

Issue Links

• links to: GitHub Pull Request #154