[MINIFICPP-2028] Remove SerializableComponent dependency from Repository

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 0.14.0
• Labels: MiNiFi-CPP-Hygiene
• Assignee: Gábor Gyimesi
• Reporter: Gábor Gyimesi
• Created: 09/Jan/23 10:46
• Updated: 09/Mar/23 13:38
• Resolved: 09/Mar/23 13:38

Description

core::Repository is inherited from SerializableComponent which is an unneeded dependency. SerializableComponent contains a lot of member functions that are not used in core::Repository and in multiple repository implementations these serialization methods aren't doing actual serialization. The serialization and deserialization semantics are also mixed up in these implementations.

The inheritance should be removed and the actual implementations in core::Repository child implementations should be renamed to reflect the actual functionality. Where SerializableComponent is actually implemented, for example in 
ProvenanceEventRecord, it should be revised to see if all Serialize/Deserialize overloads are needed.

Issue Links

• depends upon: MINIFICPP-2024 Clean up repository inheritance hierarchy
• is depended upon by: MINIFICPP-2022 Add valid repository size metrics for all repositories