[MINIFICPP-1931] ResourceQueueTests fails occasionally

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 0.13.0
• Epic Link: Fix transient test failures
• Assignee: Gábor Gyimesi
• Reporter: Ferenc Gerlits
• Created: 29/Aug/22 12:02
• Updated: 06/Sep/22 17:04
• Resolved: 06/Sep/22 17:04

Description

As of 2022-08-29, on the main branch,

ctest --repeat-until-fail 100 -R ResourceQueueTests

fails every time I run it, sometimes on the 5th run, sometimes after more than 30.

This was the failing test case in all 3 times I checked:

-------------------------------------------------------------------------------
maximum_number_of_creatable_resources
  Maximum 2 resources
-------------------------------------------------------------------------------
/home/fgerlits/src/minifi2/libminifi/test/unit/ResourceQueueTests.cpp:43
...............................................................................

/home/fgerlits/src/minifi2/libminifi/test/unit/ResourceQueueTests.cpp:54: FAILED:
  CHECK( resources_created.size() <= 2 )
with expansion:
  3 <= 2

I suspect the problem is with the test, not with the class under test, as the logs look healthy:

[2022-08-29 14:05:13.590] [LogTestController] [info] Setting log level for org::apache::nifi::minifi::utils::ResourceQueue<int> to trace
[2022-08-29 14:05:13.590] [org::apache::nifi::minifi::utils::ResourceQueue<int>] [debug] Created new [0x7f3a90000b60] resource instance. Num
ber of instances: 1 / 2.
[2022-08-29 14:05:13.590] [org::apache::nifi::minifi::utils::ResourceQueue<int>] [debug] Created new [0x7f3a88000b60] resource instance. Num
ber of instances: 2 / 2.
[2022-08-29 14:05:13.590] [org::apache::nifi::minifi::utils::ResourceQueue<int>] [debug] Waiting for resource
[2022-08-29 14:05:13.600] [org::apache::nifi::minifi::utils::ResourceQueue<int>] [debug] Returning [0x7f3a90000b60] resource
[2022-08-29 14:05:13.601] [org::apache::nifi::minifi::utils::ResourceQueue<int>] [debug] Returning [0x7f3a88000b60] resource
[2022-08-29 14:05:13.611] [org::apache::nifi::minifi::utils::ResourceQueue<int>] [debug] Returning [0x7f3a90000b60] resource