[MINIFICPP-1900] The script extension does not build on Windows

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 0.13.0
• Assignee: Ferenc Gerlits
• Reporter: Ferenc Gerlits
• Created: 08/Aug/22 15:46
• Updated: 23/Aug/22 07:59
• Resolved: 23/Aug/22 07:59

Description

If you run cmake with -DENABLE_SCRIPTING=ON on Windows, it fails when it tries to apply a patch, because of line ending differences:

patching file 'C:/Users/Ferenc Gerlits/src/minifi2/build/_deps/sol2//sol/sol.hpp'
Hunk #1 FAILED at 9746 (different line endings).
1 out of 1 hunk FAILED -- saving rejects to file 'C:/Users/Ferenc Gerlits/src/minifi2/build/_deps/sol2//sol/sol.hpp.rej'
CMake Error at cmake/Sol2.cmake:35 (message):
  Failed to patch sol.hpp
Call Stack (most recent call first):
  extensions/script/CMakeLists.txt:24 (include)

TODO:
1. Fix this.
2. Check if there are other issues.
3. Fix those.

Issue Links

• links to: GitHub pull request #1392