[MINIFICPP-1725] Upgrade Libwebsockets version and remove workaround in the LibreSSL cmake file

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 0.12.0
• Assignee: Gábor Gyimesi
• Reporter: Ferenc Gerlits
• Created: 17/Jan/22 08:51
• Updated: 14/Feb/22 10:20
• Resolved: 14/Feb/22 10:20

Description

The Libwebsockets version (v4.2-stable) we use as a dependency of kubernetes-client/c is not prepared for OpenSSL to be compiled together with it as a subproject; it expects some flavor of OpenSSL to be already present on the system.

There is a workaround for this problem in cmake/BundledLibreSSL.cmake:

    set(OPENSSL_INCLUDE_DIRS "${OPENSSL_INCLUDE_DIR}" CACHE STRING "" FORCE)  # workaround for libwebsockets

but it would be good if we did not need it.

I fixed the problem in the 4.2 version in https://github.com/warmcat/libwebsockets/pull/2535, and this fix is available in Libwebsockets version >= 4.3.1.  However, other changes in version 4.3 stop this from working again.  CMake now fails with this error:

CMake Error in build/_deps/websockets-src/lib/CMakeLists.txt:
  Target "websockets" INTERFACE_INCLUDE_DIRECTORIES property contains path:

    "/home/fgerlits/src/minifi/build/thirdparty/libressl-install/include"

  which is prefixed in the build directory.


CMake Error in build/_deps/websockets-src/lib/CMakeLists.txt:
  Target "websockets" INTERFACE_INCLUDE_DIRECTORIES property contains path:

    "/home/fgerlits/src/minifi/build/thirdparty/libressl-install/include"

  which is prefixed in the build directory.Target "websockets"
  INTERFACE_INCLUDE_DIRECTORIES property contains path:

    "/home/fgerlits/src/minifi/build/thirdparty/libressl-install/include"

  which is prefixed in the source directory.