[MINIFICPP-1696] Clean up the condition checking in behavior-based tests

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 0.12.0
• Labels: MiNiFi-CPP-Hygiene
• Assignee: Gábor Gyimesi
• Reporter: Ferenc Gerlits
• Created: 03/Dec/21 09:26
• Updated: 19/Jan/22 11:04
• Resolved: 19/Jan/22 11:04

Description

In MiNiFi_integration_test_driver.py, two types of checks are mixed up:

1. wait for x seconds, then check a condition, eg. check_for_no_files_generated
2. wait for a condition to be satisfied, but at most x seconds, eg. check_for_at_least_one_file_with_content_generated

Both types of checks try to use the same check_output function, which leads to a mess. These two, logically different, checks should use separate functions, which could then be much simpler.