[MINIFICPP-1648] InputStreamCallback OutputStreamCallback should use Input/OutputStream instead of BaseStream

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 0.13.0
• Labels: MiNiFi-CPP-Hygiene
• Assignee: Gábor Gyimesi
• Reporter: Martin Zink
• Created: 23/Sep/21 10:12
• Updated: 12/Oct/22 15:23
• Resolved: 12/Oct/22 15:23

Description

The current Input/Output callback interfaces use the BaseStream instead of the respective InputStream, OutputStream.

virtual int64_t InputStreamCallback::process(const std::shared_ptr<io::BaseStream>& stream) = 0;

virtual int64_t OutputStreamCallback::process(const std::shared_ptr<io::BaseStream>& stream) = 0;

Ideally it should look like this

virtual int64_t InputStreamCallback::process(const std::shared_ptr<io::InputStream>& stream) = 0;

virtual int64_t OutputStreamCallback::process(const std::shared_ptr<io::OutputStream>& stream) = 0;

Without this it is impossible to create and use ReadOnly/WriteOnly streams for FlowFile IO (the BaseStream requires implementing both the Input and Output Stream interfaces)

However there may be some feature dependent on this solution. (e.g. calling write from InputStreamCallback)