[MINIFICPP-1604] Upgrade rapidjson

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.10.0
• Fix Version/s: 0.11.0
• Assignee: Marton Szasz
• Reporter: Marton Szasz
• Created: 12/Jul/21 14:39
• Updated: 20/Jul/21 12:05
• Resolved: 19/Jul/21 22:50

Description

Due to this error on Mac / AppleClang:
https://github.com/szaszm/nifi-minifi-cpp/runs/3024143754#step:6:14628
It's also a warning with normal clang:

../libminifi/src/controllers/keyvalue/AbstractCoreComponentStateManagerProvider.cpp:132:23: error: ISO C++20 considers use of overloaded operator '!=' (with operand types 'rapidjson::GenericMemberIterator<[...]>' and 'rapidjson::GenericMemberIterator<[...]>') to be ambiguous despite there being a unique best viable function with non-reversed arguments [-Werror,-Wambiguous-reversed-operator]
for (const auto& kv : doc.GetObject()) {
../thirdparty/rapidjson-1.1.0/include/rapidjson/document.h:172:10: note: candidate function with non-reversed arguments
bool operator!=(ConstIterator that) const

{ return ptr_ != that.ptr_; }

 

Tencent/rapidjson has active development, but they don't seem to care about making releases. The last release is 5 years old, but the last commit on master was just 4 days ago. I propose and will submit a PR to upgrade to the current master, i.e. 48fbd8cd202ca54031fe799db2ad44ffa8e77c13.

 

The currently open known bugs are not too concerning for our uses. The parsing issues (possibly having a security impact) have already been fixed, they just forgot to close the tracking duplicate issues.