[MINIFICPP-1600] Unify temporary directory creation in tests

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 0.11.0
• Assignee: Ferenc Gerlits
• Reporter: Adam Debreceni
• Created: 05/Jul/21 13:47
• Updated: 02/Aug/21 14:55
• Resolved: 02/Aug/21 14:55

Description

There are at least two ways to create a temporary directory in tests (method(s) in TestController and a helper in TestUtils.h). Moreover these require a modifiable buffer which makes them cumbersome to use (we introduce a single-use format variable most of the time). We should change all directory creation to use a function taking 'const char*' or 'const char(&)[N]'

PR: https://github.com/apache/nifi-minifi-cpp/pull/1139 – I kept the simplest version taking no arguments at all, as I don't think we really need to control what the temporary files are called, as long as their names are unique.