[MINIFICPP-1563] Fix Wmaybe-uninitialized warnings (tested on GCC 10.3 and 11.1)

• Type: Bug
• Status: Resolved
• Priority: Trivial
• Resolution: Fixed
• Fix Version/s: 0.10.0
• Assignee: Marton Szasz
• Reporter: Marton Szasz
• Created: 20/May/21 16:19
• Updated: 25/May/21 15:24
• Resolved: 25/May/21 15:24

Description

../extensions/mqtt/../../libminifi/include/c2/PayloadSerializer.h: In function ‘static bool org::apache::nifi::minifi::c2::PayloadSerializer::deserializePayload(org::apache::nifi::minifi::c2::C2Payload&, org::apache::nifi::minifi::c2::Operation, std::string, org::apache::nifi::minifi::io::BaseStream*)’:
../extensions/mqtt/../../libminifi/include/c2/PayloadSerializer.h:233:111: error: ‘st’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
233 |       C2Payload subPayload(operation, st == 1 ? state::UpdateState::NESTED : state::UpdateState::READ_COMPLETE);
|                                                                                                               ^
../extensions/mqtt/../../libminifi/include/c2/PayloadSerializer.h:303:5: error: ‘op’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
303 |     switch (op) {
|     ^~~~~~
../extensions/mqtt/../../libminifi/include/c2/PayloadSerializer.h:225:13: note: ‘op’ was declared here
225 |     uint8_t op, st;
|             ^~
../extensions/mqtt/../../libminifi/include/c2/PayloadSerializer.h: In member function ‘virtual void org::apache::nifi::minifi::processors::ConvertHeartBeat::onTrigger(const std::shared_ptr<org::apache::nifi::minifi::core::ProcessContext>&, const std::shared_ptr<org::apache::nifi::minifi::core::ProcessSession>&)’:
../extensions/mqtt/../../libminifi/include/c2/PayloadSerializer.h:303:5: error: ‘op’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
303 |     switch (op) {
|     ^~~~~~
../extensions/mqtt/../../libminifi/include/c2/PayloadSerializer.h:260:13: note: ‘op’ was declared here
260 |     uint8_t op, st = 0;
|             ^~

 

and more...