[MINIFICPP-1502] Update processors that take their name/id constructor arguments as values

• Type: Task
• Status: Resolved
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 0.7.0
• Fix Version/s: 0.10.0
• Labels: MiNiFi-CPP-Hygiene
• Assignee: Gábor Gyimesi
• Reporter: Adam Hunyadi
• Created: 17/Feb/21 15:21
• Updated: 31/May/21 14:57
• Resolved: 28/Apr/21 07:16

Description

Background:

Currently, probably due to copy-pasting, many of the processors take their name and id arguments as values as opposed to const references.

➜  git --no-pager grep '(std::string name, utils::Identifier uuid = utils::Identifier())' | wc -l
46

Proposal:

It should be a trivial change to update these signatures. One should search and replace the mentioned signature and check if changing it has no impact (eg. values are not moved from).