[MINIFICPP-1190] RocksDB fails to build on Clang 10

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.9.0
• Assignee: Marton Szasz
• Reporter: Marton Szasz
• Created: 09/Apr/20 14:28
• Updated: 25/May/21 15:31
• Resolved: 14/Apr/20 19:33

Description

Our self-built third-party, RocksDB, fails to build on clang. The upstream is already patched, but our version is older.

The issue is that a const member function tries to lock a mutex that's not marked as mutable in a rocksdb class. It should never have compiled, but it did. Now it fails correctly.

The supplied patch marks the mutex as mutable.

Thanks to bakaid for assistance on how to apply third-party patches.

Issue Links

• links to: GitHub Pull Request #752