[MINIFI-54] ConfigSchema duplicate validation only works when processors is not null

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.1.0
• Assignee: Bryan Rosander
• Reporter: Bryan Rosander
• Created: 07/Jul/16 18:12
• Updated: 08/Jul/16 17:56
• Resolved: 08/Jul/16 14:44

Description

ConfigSchema has logic to detect duplicate processor, connection, and remote processing group names. This is to help MiNiFi ensure it can generate a valid flow.

Unfortunately, the check is short circuited if processors are null, regardless of which duplicates it is checking for, causing for possibly missing validation errors.

https://github.com/apache/nifi-minifi/blob/2d1e43e73b90df55abc71845160b6422d7a6f03f/minifi-commons/minifi-commons-schema/src/main/java/org/apache/nifi/minifi/commons/schema/ConfigSchema.java#L122

Should be changed to a null check on the names parameter

Issue Links

• links to: GitHub Pull Request #30