[MINIFI-497] С2 Server: wrong regex pattern in "getConfiguration" (NiFiRestConfigurationProvider.java)

• Type: Bug
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 0.5.0
• Fix Version/s: 1.14.0
• Component/s: Command and Control
• Labels: easyfix
• Assignee: Vladimir Mikhailov
• Reporter: Vladimir Mikhailov
• Created: 25/Mar/19 05:10
• Updated: 28/Apr/21 15:59
• Resolved: 29/Mar/19 15:31

Description

C2 Server can't get from NiFi templates with versions v10+, only v1-v9.

The reason is an error in the "getConfiguration" function, where "filenamePattern" is determined.

Wrong code (maybe a typo?):

String filenamePattern = Arrays.stream(filename.split(Pattern.quote("${version}"), -1)).map(Pattern::quote).collect(Collectors.joining("([0-9+])"));

It should be:

String filenamePattern = Arrays.stream(filename.split(Pattern.quote("${version}"), -1)).map(Pattern::quote).collect(Collectors.joining("([0-9]+)"));

[0-9+] -> [0-9]+

Link to source code:

https://github.com/apache/nifi-minifi/blob/master/minifi-c2/minifi-c2-provider/minifi-c2-provider-nifi-rest/src/main/java/org/apache/nifi/minifi/c2/provider/nifi/rest/NiFiRestConfigurationProvider.java#L105

Issue Links

• links to: GitHub Pull Request #151