Uploaded image for project: 'Apache NiFi MiNiFi - MOVED TO NIFI PROJECT'
  1. Apache NiFi MiNiFi - MOVED TO NIFI PROJECT
  2. MINIFI-420

Cached Windows service executables can leak into generated source packages

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 0.3.0
    • 0.3.0
    • Build
    • None

    Description

      During the RC2 of the MiNiFi 0.3.0 release it was identified that the candidate source package had executables in it related to the Windows service enablement.

      The files are provided such that we cache them so that there is no need to repeatedly download the package assembly.

      Given that .exe is also in .gitignore, a git clean -fd would not remove these. (-fxd would)

      There are two options that come to mind to help remedy this issue and make things a bit less error prone. One is to move the acquired executables and package to target. However, given that most folks are likely to do a mvn clean <goals> this would likely defeat the purpose of caching entirely. The other option is to provide configuration to the maven source plugin to exclude these items. This would allow us to more effectively cache these items but also provide a clean source release that would function as anticipated on build.

      Attachments

        Issue Links

          Activity

            People

              aldrin Aldrin Piri
              ijokarumawak Koji Kawamura
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: