[MINDEXER-185] Document filter doesn't seem to do anything

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 7.0.1
• Fix Version/s: 7.0.2
• Assignee: Tamas Cservenak
• Reporter: Michael Bien
• Created: 12/Mar/23 05:11
• Updated: 08/May/23 16:22
• Resolved: 08/May/23 16:22

Description

Hello devs!

 

I tried to filter the index during extraction using a DocumentFilter and it didn't appear to do anything.

As test, I simply set indexUpdateRequest.setDocumentFilter(doc -> false); before calling DefaultIndexUpdater.fetchAndUpdateIndex and the extracted index had the same size of 5.6gb as without the filter.

 

The filter is actually called and it does also add a few minutes to the extraction time.

https://github.com/apache/maven-indexer/blob/1cd122b1487150613005c8f9aced9aec20fded3e/indexer-core/src/main/java/org/apache/maven/index/updater/DefaultIndexUpdater.java#L238-L241

 

I am not sure why the implementation is filtering the index after extraction. Wouldn't it be easier and also more efficient to do it in IndexDataReader?
e.g https://github.com/apache/maven-indexer/blob/1cd122b1487150613005c8f9aced9aec20fded3e/indexer-core/src/main/java/org/apache/maven/index/updater/IndexDataReader.java#L269