[MIME4J-222] MessageImplFactory is needed

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.8.0
• Fix Version/s: 0.8.0
• Component/s: parser (core)
• Assignee: Ioan Eugen Stan
• Reporter: Raman Gupta
• Created: 10/Mar/13 16:37
• Updated: 17/Mar/13 12:08
• Resolved: 17/Mar/13 12:08

Description

In order to create a custom Message-Id, one must currently override the method "newMessageId" e.g.

return new MessageImpl() {
@Override
protected UnstructuredField newMessageId(String hostname)

{ String fieldValue = createUniqueMessageId(hostname); return parse(UnstructuredFieldImpl.PARSER, FieldName.MESSAGE_ID, fieldValue); }

};

However, in some cases Mime4j instantiates the MessageImpl internally e.g. DefaultMessageBuilder.parseMessage and therefore the newMessageId function cannot be overwridden. This means that I cannot use DefaultMessageBuilder to create a MessageImpl in which I control how the Message-Id is created.

I have attached a patch to make DefaultMessageBuilder take a MessageImplFactory to create the MessageImpl.