[MFCOMMONS-26] validateRegExpr doesnt support value binding in patter property

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Fix Version/s: 1.0.1
• Component/s: myfaces-commons-validators
• Assignee: Leonardo Uribe
• Reporter: Tomasz Bech
• Created: 03/Dec/08 16:16
• Updated: 09/Dec/10 01:39
• Resolved: 23/Nov/10 18:49

Description

As from version 1.1.7 validateRegExpr tag desn't support value binding in pattern field.

ValidateRegExprTag.java
Version 1.1.6 has:
protected Validator createValidator() throws JspException {

FacesContext facesContext = FacesContext.getCurrentInstance();
setValidatorId(RegExprValidator.VALIDATOR_ID);
RegExprValidator validator = (RegExprValidator)super.createValidator();
if (_pattern != null)
{
if (UIComponentTag.isValueReference(_pattern))

{ ValueBinding vb = facesContext.getApplication().createValueBinding(_pattern); validator.setPattern(new String(vb.getValue(facesContext).toString())); }

else

{ validator.setPattern(_pattern); }

}

return validator;
}

Version 1.1.7 has:
protected Validator createValidator() throws JspException {

FacesContext facesContext = FacesContext.getCurrentInstance();
setValidatorId("org.apache.myfaces.validator.RegExpr");
org.apache.myfaces.custom.regexprvalidator.RegExprValidator validator = (org.apache.myfaces.custom.regexprvalidator.RegExprValidator)super.createValidator();
if (_pattern != null)

{ validator.setPattern(_pattern); }

return validator;
}