[METRON-726] Clean up mvn site generation

• Type: Bug
• Status: Done
• Priority: Minor
• Resolution: Done
• Fix Version/s: 0.4.0
• Assignee: Justin Leet
• Reporter: Justin Leet
• Created: 20/Feb/17 05:22
• Updated: 27/Jun/17 00:08
• Resolved: 02/May/17 22:18

Description

Right now there's a couple issues with running mvn:site. The most obvious is that EMMA appears to not work at all, but in attempting to fix that, several other issues came to light.

Error seen:

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-site-plugin:3.3:site (default-site) on project metron-maas-common: failed to get report for org.codehaus.mojo:emma-maven-plugin: Failed to execute goal org.codehaus.mojo:emma-maven-plugin:1.0-alpha-3:instrument (report:emma) on project metron-maas-common: Execution report:emma of goal org.codehaus.mojo:emma-maven-plugin:1.0-alpha-3:instrument failed: CONSTANT_info: invalid tag value [18] -> [Help 1]

After commenting out everything EMMA, there are still some issues seen:

[WARNING] Unable to process class org/apache/metron/test/converters/BinaryConverters.class in JarAnalyzer File /Users/jleet/.m2/repository/org/apache/metron/metron-test-utilities/0.3.1/metron-test-utilities-0.3.1.jar
org.apache.bcel.classfile.ClassFormatException: Invalid byte tag in constant pool: 18

This seems to be a Java 8 issue, which means that EMMA likely is impossible to make work. I'm unsure that's the root cause, but given the age of EMMA plus (the outdated version of) BCEL thowing a very similar issue implies that the Java version is related. This also implies that our mvn site hasn't worked in a long time.

Cleaning this up should include at least

• Getting code coverage working again
• Consolidating reporting in our poms. A lot of it is repeated everywhere we have Java.
• Ensure we can actually generate and look through the site.
• METRON-725 fixes Javadoc, so reporting will still have issues until that is taken care of.
• Apparently checkstyle got dropped at some point. It's easy enough to add in, and can be taken care of here.

Issue Links

• is related to: METRON-718 integrate versioned site-book to public site (Metron home page)
• relates to: METRON-759 integrate javadoc to public site (Metron home page)
• links to: GitHub Pull Request #459