[METRON-2172] Solr Updates Not Tested in Integration Test

• Type: Bug
• Status: Done
• Priority: Major
• Resolution: Done
• Fix Version/s: Next + 1
• Assignee: Nick Allen
• Reporter: Nick Allen
• Created: 02/Jul/19 13:44
• Updated: 04/Dec/19 22:40
• Resolved: 04/Dec/19 22:40

Description

The `SolrUpdateIntegrationTest` is not testing that the `SolrDao` can update and retrieve values in a manner similar to what would occur in production.

What?

This gap in the integration test is hiding a few existing bugs in the SolrUpdateIntegrationTest.

1. The timestamp is not being populated in the returned documents.
2. A NullPointerException occurs if a document does not contain a sensor type.
3. The comments are serialized and deserialized in multiple places and may be stored as either a Map or JSON string.

Proof?

 If you alter the test to run against just a `SolrDao` the integration test will fail.

Issue Links

• links to: GitHub Pull Request #1454
• links to: GitHub Pull Request #1465