[METRON-1944] Unable to Delete a Comment in Alerts UI

• Type: Bug
• Status: Done
• Priority: Major
• Resolution: Done
• Fix Version/s: 0.7.1
• Assignee: Tamas Fodor
• Reporter: Tamas Fodor
• Created: 19/Dec/18 14:45
• Updated: 25/Apr/19 12:36
• Resolved: 25/Apr/19 12:36

Description

I am unable to delete a comment in the Alerts UI. While it appears that the comment is deleted, it is only deleted locally, but not server side. An exception is thrown in the browser console.

ERROR TypeError: Cannot read property 'alertComment' of undefined at SafeSubscriber._next (alert-details.component.ts:258) at SafeSubscriber.push../node_modules/rxjs/_esm5/internal/Subscriber.js.SafeSubscriber.__tryOrUnsub (Subscriber.js:207) at SafeSubscriber.push../node_modules/rxjs/_esm5/internal/Subscriber.js.SafeSubscriber.next (Subscriber.js:145) at Subscriber.push../node_modules/rxjs/_esm5/internal/Subscriber.js.Subscriber._next (Subscriber.js:80) at Subscriber.push../node_modules/rxjs/_esm5/internal/Subscriber.js.Subscriber.next (Subscriber.js:55) at Subject.push../node_modules/rxjs/_esm5/internal/Subject.js.Subject.next (Subject.js:47) at DialogService.push../src/app/service/dialog.service.ts.DialogService.approve (dialog.service.ts:49) at MetronDialogComponent.push../src/app/shared/metron-dialog/metron-dialog.component.ts.MetronDialogComponent.confirm (metron-dialog.component.ts:54) at Object.handleEvent (login-guard.ts:40) at handleEvent (core.js:10258)

Steps To Replicate

1. Find an Alert
2. Comment on the alert.
3. Delete the comment.  
4. Close the side panel.
5. Search for the alert again.
6. Click on the alert and the comment remains.

 

Issue Links

• incorporates: METRON-1898 Migrate existing e2e tests in Alerts UI to Cypress
• links to: GitHub Pull Request #1307