Uploaded image for project: 'Metron (Retired)'
  1. Metron (Retired)
  2. METRON-1633

Incorrect instructions when merging PR into feature branch

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Done
    • Minor
    • Resolution: Done
    • None
    • 0.6.0
    • None

    Description

      The 'dev-utilities/committer-utils/prepare-commit' script can be used to merge PRs against a feature branch. The script automatically determines which branch the PR should be merged into based on how the contributor submitted the PR.

      Instructions are offered at the end of the script, after the local merge has completed. These instructions are incorrect when merging into a feature branch.

      When merging into a feature branch, the instructions say...

      Review commit carefully then run...
          cd /Users/nallen/tmp/metron-pr1056
          git push upstream master
      

      But they should say...

      Review commit carefully then run...
          cd /Users/nallen/tmp/metron-pr1056
          git push upstream feature/METRON-1416-upgrade-solr
      

      Attachments

        Issue Links

          Activity

            People

              nickwallen Nick Allen
              nickwallen Nick Allen
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: