[MESOS-9956] CSI plugins reporting duplicated volumes will crash the agent.

• Type: Bug
• Status: Resolved
• Priority: Blocker
• Resolution: Fixed
• Fix Version/s: 1.9.0, 1.8.2
• Component/s: storage
• Labels: mesosphere storage
• Target Version/s: 1.9.0
• Epic Link: Improve experience of operating CSI plugins
• Sprint: Storage: RI-18 54
• Story Points: 2
• Assignee: Chun-Hung Hsiao
• Reporter: Chun-Hung Hsiao
• Shepherd: Benno Evers
• Created: 29/Aug/19 21:52
• Updated: 27/Nov/19 12:06
• Resolved: 30/Aug/19 11:07

Description

The CSI spec requires volumes to be uniquely identifiable by ID, and thus SLRP currently assumes that a ListVolumes call does not return duplicated volumes. However, if a SLRP uses a non-conforming CSI plugin that reports duplicated volumes, these volumes would corrupt the SLRP checkpoint and cause the agent to crash at the next reconciliation:

 F0829 07:13:55.171332 12721 provider.cpp:1089] Check failed: !checkpointedMap.contains(resource.disk().source().id())

MESOS-9254 introduces periodic reconciliation which make this problem much easier to manifest.