[MESOS-9870] Simultaneous adding/removal of a role from framework's roles and its suppressed roles crashes the master.

• Type: Bug
• Status: Resolved
• Priority: Blocker
• Resolution: Fixed
• Fix Version/s: 1.5.4, 1.6.3, 1.7.3, 1.8.1, 1.9.0
• Labels: resource-management
• Target Version/s: 1.5.4, 1.6.3, 1.7.3, 1.8.1, 1.9.0
• Epic Link: Multi-role Scalibility
• Sprint: Resource Mgmt: RI 15 Sp 49, Resource Mgmt: RI-16 Sp 50
• Story Points: 5
• Assignee: Andrei Sekretenko
• Reporter: Andrei Sekretenko
• Created: 27/Jun/19 16:17
• Updated: 03/Jul/19 22:01
• Resolved: 03/Jul/19 21:09

Description

Calling UPDATE_FRAMEWORK with a new role added both to 'FrameworkInfo.roles` and `suppressed_roles` crashes the master.

The first place which doesn't expect this is increasing a `suppressed` allocator metric:
https://github.com/apache/mesos/blob/fe7be9701e92d863734621ae1a3d339bb8598044/src/master/allocator/mesos/hierarchical.cpp#L507
[
https://github.com/apache/mesos/blob/fe7be9701e92d863734621ae1a3d339bb8598044/src/master/allocator/mesos/metrics.cpp#L255]

Probably there are other similar places.
Adding a new role in a suppressed state via re-subscribing  should also trigger this bug - haven't checked it

Issue Links

• relates to: MESOS-9793 Implement UPDATE_FRAMEWORK call in V0 API for C++/Java