[MESOS-9672] Docker containerizer should ignore pids of executors that do not pass the connection check.

• Type: Bug
• Status: Resolved
• Priority: Critical
• Resolution: Won't Fix
• Component/s: containerization
• Labels: containerization
• Sprint: Containerization: RI13 Sp 45
• Story Points: 2
• Assignee: Qian Zhang
• Reporter: Meng Zhu
• Created: 22/Mar/19 23:04
• Updated: 01/May/19 03:29
• Resolved: 01/May/19 03:29

Description

When recovering executors with a tracked pid we first try to establish a connection to its libprocess address to avoid reaping an irrelevant process:

https://github.com/apache/mesos/blob/4580834471fb3bc0b95e2b96e04a63d34faef724/src/slave/containerizer/docker.cpp#L1019-L1054

If the connection fails to establish, we should not track its pid: https://github.com/apache/mesos/blob/4580834471fb3bc0b95e2b96e04a63d34faef724/src/slave/containerizer/docker.cpp#L1071

One trouble this might cause is that if the pid is being used by another executor, this could lead to duplicate pid error and lead the agent into a crash loop:

https://github.com/apache/mesos/blob/4580834471fb3bc0b95e2b96e04a63d34faef724/src/slave/containerizer/docker.cpp#L1066-L1068

Issue Links

• is related to: MESOS-8125 Agent should properly handle recovering an executor when its pid is reused
• is related to: MESOS-9695 Remove the duplicate pid check in Docker containerizer
• relates to: MESOS-9501 Mesos executor fails to terminate and gets stuck after agent host reboot.