[MESOS-9661] Agent crashes when SLRP recovers dropped operations.

• Type: Bug
• Status: Resolved
• Priority: Blocker
• Resolution: Fixed
• Affects Version/s: 1.7.2
• Fix Version/s: 1.7.3, 1.8.0
• Component/s: storage
• Labels: mesosphere mesosphere-dss-beta storage
• Target Version/s: 1.7.3, 1.8.0
• Epic Link: Resource Provider and CSI Tech Debt
• Sprint: Storage R11 Sprint 40
• Story Points: 1
• Assignee: Chun-Hung Hsiao
• Reporter: Chun-Hung Hsiao
• Shepherd: Benjamin Bannier
• Created: 18/Mar/19 18:12
• Updated: 18/Mar/19 20:47
• Resolved: 18/Mar/19 20:47

Description

MESOS-9537 is fixed by persisting dropped operations in SLRP, but the recovery codepath doesn't account for that:
https://github.com/apache/mesos/blob/master/src/resource_provider/storage/provider.cpp#L1278
Which caused the agent to crash with the following message during SLRP recovery:

Reached unreachable statement at /pkg/src/mesos/src/resource_provider/storage/provider.cpp:1283