[MESOS-9612] Resource provider manager assumes all operations are triggered by frameworks

• Type: Bug
• Status: Resolved
• Priority: Blocker
• Resolution: Fixed
• Fix Version/s: 1.8.0
• Component/s: agent
• Labels: mesosphere mesosphere-dss-ga storage
• Target Version/s: 1.8.0
• Epic Link: Resource Provider and CSI Tech Debt
• Sprint: Storage R11 Sprint 40, Storage: RI-12 Sprint 43
• Story Points: 5
• Assignee: Jan Schlicht
• Reporter: Benjamin Bannier
• Shepherd: Benjamin Bannier
• Created: 26/Feb/19 17:14
• Updated: 01/Apr/19 10:45
• Resolved: 27/Mar/19 12:55

Description

When the agent tries to apply an operation to resource provider resources, it invokes ResourceProviderManager::applyOperation which in turn invokes ResourceProviderManagerProcess::applyOperation. That function currently assumes that the received message contains a valid FrameworkID,

 void ResourceProviderManagerProcess::applyOperation(
      const ApplyOperationMessage& message)                                                                                                                                                                                                     {
    const Offer::Operation& operation = message.operation_info();                                                                                                                                                                                 
    const FrameworkID& frameworkId = message.framework_id(); // `framework_id` is `optional`.

Since FrameworkID is not a trivial proto types, but instead one with a required field value, the message composed with the frameworkId below cannot be serialized which leads to a failure below which in turn triggers a CHECK failure in the agent's function interfacing with the manager.

A typical scenario where we would want to support operator API calls here is to destroy leftover persistent volumes or reservations.