[MESOS-9305] Create cgoup recursively to workaround systemd deleting cgroups_root.

• Type: Improvement
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 1.5.1, 1.6.1, 1.7.0
• Fix Version/s: 1.5.3, 1.6.2, 1.7.1, 1.8.0
• Component/s: containerization
• Labels: containerizer
• Target Version/s: 1.5.2, 1.6.2, 1.7.1
• Epic Link: cgroups-isolator-improvements
• Sprint: Mesosphere RI-6 Sprint 2018-30, Mesosphere RI-6 Sprint 2018-31
• Story Points: 3
• Assignee: longfei
• Reporter: longfei
• Shepherd: Jie Yu
• Created: 10/Oct/18 02:55
• Updated: 07/Nov/18 17:28
• Resolved: 28/Oct/18 04:51

Description

This is my case:

My cgroups_root of mesos-slave is some_user/mesos under /sys/fs/cgroup。

It happens that this some_user dir may be gone for some unknown reason, in which case I can no longer create any cgroup and any task will fail.

So I would like to change 

 

Try<Nothing> create = cgroups::create(
hierarchy,
infos[containerId]->cgroup);

to

Try<Nothing> create = cgroups::create(
hierarchy,
infos[containerId]->cgroup,
true);

in CgroupsIsolatorProcess::prepare in src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp.

However, I'm not sure if there's any potential problem doing so. Any advice?

 

Issue Links

• relates to: MESOS-9362 Test `CgroupsIsolatorTest.ROOT_CGROUPS_CreateRecursively` is flaky.