[MESOS-9168] Libprocess' http client does not encode the outgoing query.

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.7.0
• Fix Version/s: 1.8.0
• Component/s: libprocess
• Labels: libprocess
• Assignee: Andrew Schwartzmeyer
• Reporter: Andrew Schwartzmeyer
• Shepherd: Benjamin Mahler
• Created: 20/Aug/18 21:59
• Updated: 04/Sep/18 21:37
• Resolved: 04/Sep/18 21:37

Description

During testing of another bug, it was found that we have an unequal number of encode/decode cycles in libprocess. This meant that, when given a query such as ?path=C%3A%5Cfoo%5Cbar%253Abaz, it would erroneously go over the wire as C:\\foo
bar%3Abaz, and then once decoded on the other end, it would look for C:\\foo
bar:baz even though the query was trying to express the literal value C:\\foo
bar%3Abaz.

Essentially, we were missing an encode in http::internal::encode(Request).