[MESOS-9114] cmake build is broken on macos

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.7.0
• Fix Version/s: 1.7.0

Environment

Currently broken e.g., macos-10.13.6, and passes on fedora-25.

• Assignee: Chun-Hung Hsiao
• Reporter: Benjamin Bannier
• Created: 26/Jul/18 21:38
• Updated: 27/Jul/18 18:44
• Resolved: 27/Jul/18 18:44

Description

Since the changes for MESOS-9092 have landed it seems impossible to perform a cmake-based build on macos. This seems independent of the used generator and both make and ninja-based builds appear broken, e.g.,

# cmake ~/src/mesos
# make stout-tests
...
 87%] Building CXX object 3rdparty/stout/tests/CMakeFiles/stout-tests.dir/uuid_tests.cpp.o
In file included from /Users/bbannier/src/mesos/3rdparty/stout/tests/json_tests.cpp:24:
In file included from /Users/bbannier/src/mesos/3rdparty/stout/include/stout/json.hpp:41:
/Users/bbannier/src/mesos/3rdparty/stout/include/stout/jsonify.hpp:36:10: fatal error: 'rapidjson/stringbuffer.h' file not found
#include <rapidjson/stringbuffer.h>
         ^~~~~~~~~~~~~~~~~~~~~~~~~~
...

As a workaround I can apply the following patch,

diff --git a/3rdparty/CMakeLists.txt b/3rdparty/CMakeLists.txt
index 9b0dfe0ab..b244267e8 100644
--- a/3rdparty/CMakeLists.txt
+++ b/3rdparty/CMakeLists.txt
@@ -440,9 +440,7 @@ EXTERNAL(rapidjson ${RAPIDJSON_VERSION} ${CMAKE_CURRENT_BINARY_DIR})
 add_library(rapidjson INTERFACE)
 add_dependencies(rapidjson ${RAPIDJSON_TARGET})

-target_include_directories(
-    rapidjson INTERFACE
-    ${RAPIDJSON_ROOT}/rapidjson-${RAPIDJSON_VERSION}/include)
+target_include_directories(rapidjson INTERFACE ${RAPIDJSON_ROOT}/include)

 ExternalProject_Add(
   ${RAPIDJSON_TARGET}

This however seems to break cmake-based builds on Linux.

Issue Links

• is caused by: MESOS-9092 Adopt rapidjson for improved json serialization performance.
• is duplicated by: MESOS-9115 Stout depends on missing rapidjson headers.