Uploaded image for project: 'Mesos'
  1. Mesos
  2. MESOS-9112

mesos-style reports violations on a clean checkout

    XMLWordPrintableJSON

    Details

    • Sprint:
      Mesosphere Sprint 2018-28
    • Story Points:
      2

      Description

      When running support/mesos-style.py on a clean checkout of e.g., e879e920c35 Python style violations are reported,

      Checking 46 Python files
      Using config file /home/bbannier/src/mesos/support/pylint.config
      ************* Module cli.plugins.base
      E:119, 0: Bad option value 'R0204' (bad-option-value)
      ************* Module settings
      E: 32, 4: No name 'VERSION' in module 'version' (no-name-in-module)
      Using config file /home/bbannier/src/mesos/support/pylint.config
      ************* Module mesos.http
      E: 25, 0: Unable to import 'urlparse' (import-error)
      E: 87,30: Undefined variable 'xrange' (undefined-variable)
      Using config file /home/bbannier/src/mesos/support/pylint.config
      ************* Module apply-reviews
      R: 99, 0: Either all return statements in a function should return an expression, or none of them should. (inconsistent-return-statements)
      C:124, 9: Do not use `len(SEQUENCE)` to determine if a sequence is empty (len-as-condition)
      R:302, 4: Unnecessary "else" after "return" (no-else-return)
      ************* Module generate-endpoint-help
      R:215, 4: Unnecessary "else" after "return" (no-else-return)
      ************* Module verify-reviews
      C:261, 7: Do not use `len(SEQUENCE)` to determine if a sequence is empty (len-as-condition)
      Total errors found: 9
      

      I would expect a clean checkout to not report any violations.

        Attachments

          Activity

            People

            • Assignee:
              ArmandGrillet Armand Grillet
              Reporter:
              bbannier Benjamin Bannier
              Shepherd:
              Benjamin Bannier
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: