[MESOS-8908] Add -fno-omit-frame-pointer to improve debugging and profiling.

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.7.0
• Component/s: build, libprocess, stout
• Assignee: Benjamin Bannier
• Reporter: Benjamin Mahler
• Shepherd: Benjamin Mahler
• Created: 11/May/18 21:21
• Updated: 29/Apr/19 09:26
• Resolved: 21/May/18 21:12

Description

Currently, we build without -fno-omit-frame-pointer which is needed to get reliable stack traces. Without this, obtaining perf profiles from users is not reliable:

http://www.brendangregg.com/FlameGraphs/cpuflamegraphs.html#C

Apparently, the performance win from frame pointer omission is very minor and many projects opt to disable the optimization given the benefits to debugging and profiling.

I tried the --call-graph dwarf "workaround" for perf but still experienced [unknown] stack frames and what looked to be missing frames:

http://www.brendangregg.com/perf.html#StackTraces (see dwarf section)

Issue Links

• relates to: MESOS-6229 Default to using hardened compilation flags